-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
Open question before merging: right now, gax does not directly depend on any of the transports needed for google-auth. It will check for requests, then httplib2, then give up code. We have options:
|
How much work would this be?
How does that work in principle? If I were to add a dependency on urllib3 somewhere, would urllib3 objects get picked up instead of httplib2? (Summoning @dhermes). Note that this is related to googleapis/google-cloud-python#1998 which is @dhermes current project this week. |
Indeed, this should be the place we end up. Fewer round trips are better for everyone. |
Not much, once googleapis/google-auth-library-python#136 is done it's just a matter of
We'd have to add a little code to use urllib3 (currently this code just uses requests or httplib2), but yeah, if someone directly constructed a gapic client without a channel or credentials, then it would use whatever transport we depend on here. This is independent of That is to say, in practice we can go ahead and make this library use urllib3 for the transport and it won't break |
Oh, another thing for jwt-only credentials: we should verify independently that every API supports this. I've only ever tested with pubsub and bigtable. |
We can always just tell those credentials to go away. Also, for GCE creds, won't there be a local bytes signing API at some point? |
We can't, we need to support every case that ADC supports.
Yes but no timeline on that. :) |
bump? |
👏 |
Closes #155 and #175